Apply inferface change to duplicated code in the tgis layer #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
joerunde
pushed a commit
that referenced
this pull request
Jun 19, 2024
In the upstream code the `init_state()` method was removed from the
Outlines logits processor classes but the call to this method was still
in our tgis layer causing this error:
```
ERROR 06-19 16:12:57 logs.py:77] generate{input=[b'Hello, I am here to'] prefix_id= adapter_id= input_chars=[19] params=decoding { format: JSON }: 'CFGLogitsProcessor' object has no attribute 'init_state'
ERROR 06-19 16:12:57 grpc_server.py:86] Generate failed
ERROR 06-19 16:12:57 grpc_server.py:86] Traceback (most recent call last):
ERROR 06-19 16:12:57 grpc_server.py:86] File "/opt/vllm/lib/python3.11/site-packages/vllm/entrypoints/grpc/grpc_server.py", line 103, in func_with_log
ERROR 06-19 16:12:57 grpc_server.py:86] return await func(*args, **kwargs)
ERROR 06-19 16:12:57 grpc_server.py:86] ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 06-19 16:12:57 grpc_server.py:86] File "/opt/vllm/lib/python3.11/site-packages/vllm/entrypoints/grpc/grpc_server.py", line 153, in Generate
ERROR 06-19 16:12:57 grpc_server.py:86] sampling_params, deadline = await self._validate_and_convert_params(
ERROR 06-19 16:12:57 grpc_server.py:86] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 06-19 16:12:57 grpc_server.py:86] File "/opt/vllm/lib/python3.11/site-packages/vllm/entrypoints/grpc/grpc_server.py", line 430, in _validate_and_convert_params
ERROR 06-19 16:12:57 grpc_server.py:86] await get_outlines_guided_decoding_logits_processor(decoding,
ERROR 06-19 16:12:57 grpc_server.py:86] File "/opt/vllm/lib/python3.11/site-packages/vllm/tgis_utils/guided_decoding.py", line 44, in get_outlines_guided_decoding_logits_processor
ERROR 06-19 16:12:57 grpc_server.py:86] logits_processor.init_state()
ERROR 06-19 16:12:57 grpc_server.py:86] ^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
---------
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream code the
init_state()method was removed from the Outlines logits processor classes but the call to this method was still in our tgis layer causing this error: